From: Mattias Engdegård <mattiase@acm.org>
Date: Tue, 11 Apr 2023 09:57:07 +0000 (+0200)
Subject: nndiary.el: fix dodgy schedule code
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fb66e4d58bbc24abf44157078e8ca51ffed93113;p=emacs.git

nndiary.el: fix dodgy schedule code

* lisp/gnus/nndiary.el (nndiary-last-occurrence):
Don't sort a list and throw away the result because that leaves the
list variable in an undefined state.  Just take the largest element
because that was obviously what the author meant.
---

diff --git a/lisp/gnus/nndiary.el b/lisp/gnus/nndiary.el
index be2bdc9bb15..8728aab1def 100644
--- a/lisp/gnus/nndiary.el
+++ b/lisp/gnus/nndiary.el
@@ -1373,10 +1373,10 @@ all.  This may very well take some time.")
 		       (setq day (+ 7 day))))
 		   ;; Finally, if we have some days, they are valid
 		   (when days
-		     (sort days #'>)
 		     (throw 'found
 			    (encode-time 0 minute hour
-					 (car days) month year time-zone)))
+					 (apply #'max days)
+                                         month year time-zone)))
 		   )))))
 	 ;; There's an upper limit, but we didn't find any last occurrence.
 	 ;; This means that the schedule is undecidable. This can happen if