From: Noam Postavsky Date: Sat, 1 Jun 2019 16:40:11 +0000 (-0400) Subject: Don't recommend insert-before-markers in process filters X-Git-Tag: emacs-26.2.90~25 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fb314ba;p=emacs.git Don't recommend insert-before-markers in process filters See and Bug#35334. * doc/lispref/processes.texi (Filter Functions): Go back to using plain insert in the example filter. Add note about updating window point. --- diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi index 38ad9076a0c..a93f4db4282 100644 --- a/doc/lispref/processes.texi +++ b/doc/lispref/processes.texi @@ -1643,7 +1643,7 @@ how to do these things: (save-excursion ;; @r{Insert the text, advancing the process marker.} (goto-char (process-mark proc)) - (insert-before-markers string) + (insert string) (set-marker (process-mark proc) (point))) (if moving (goto-char (process-mark proc))))))) @end group @@ -1659,7 +1659,12 @@ text arrives, you could insert a line like the following just before the To force point to the end of the new output, no matter where it was previously, eliminate the variable @code{moving} from the example and -call @code{goto-char} unconditionally. +call @code{goto-char} unconditionally. Note that this doesn't +necessarily move the window point. The default filter actually uses +@code{insert-before-markers} which moves all markers, including the +window point. This may move unrelated markers, so it's generally +better to move the window point explicitly, or set its insertion type +to @code{t} (@pxref{Window Point}). @ignore In earlier Emacs versions, every filter function that did regular