From: Richard M. Stallman <rms@gnu.org>
Date: Mon, 4 Aug 1997 04:23:51 +0000 (+0000)
Subject: (internal-face-interactive): Handle default in usual way,
X-Git-Tag: emacs-20.1~821
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f60a629a96cfbeb5a9a88750122f951821333566;p=emacs.git

(internal-face-interactive): Handle default in usual way,
Provide completion for color reading.
(set-face-foreground, set-face-background): Specify `color'
when reading the color name interactively.
---

diff --git a/lisp/faces.el b/lisp/faces.el
index cfa5b223b7f..f0a0e5ada46 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -189,7 +189,7 @@ in that frame; otherwise change each frame."
   "Change the foreground color of face FACE to COLOR (a string).
 If the optional FRAME argument is provided, change only
 in that frame; otherwise change each frame."
-  (interactive (internal-face-interactive "foreground"))
+  (interactive (internal-face-interactive "foreground" 'color))
   (internal-set-face-1 face 'foreground color 4 frame))
 
 (defvar face-default-stipple "gray3" 
@@ -214,7 +214,7 @@ FRAME specifies the frame and thus the display for interpreting COLOR."
   "Change the background color of face FACE to COLOR (a string).
 If the optional FRAME argument is provided, change only
 in that frame; otherwise change each frame."
-  (interactive (internal-face-interactive "background"))
+  (interactive (internal-face-interactive "background" 'color))
   ;; For a specific frame, use gray stipple instead of gray color
   ;; if the display does not support a gray color.
   (if (and frame (not (eq frame t)) color
@@ -455,11 +455,20 @@ If NAME is already a face, it is simply returned."
 	 (default (if (fboundp fn)
 		      (or (funcall fn face (selected-frame))
 			  (funcall fn 'default (selected-frame)))))
-	 (value (if bool
-		    (y-or-n-p (concat "Should face " (symbol-name face)
-				      " be " bool "? "))
-		  (read-string (concat prompt " " (symbol-name face) " to: ")
-			       default))))
+	 value)
+    (setq value
+	  (cond ((eq bool 'color)
+		 (completing-read (concat prompt " " (symbol-name face) " to: ")
+				  (mapcar (function (lambda (color)
+						      (cons color color)))
+					  x-colors)
+				  nil nil nil nil default))
+		(bool
+		 (y-or-n-p (concat "Should face " (symbol-name face)
+				   " be " bool "? ")))
+		(t
+		 (read-string (concat prompt " " (symbol-name face) " to: ")
+			      nil nil default))))
     (list face (if (equal value "") nil value))))
 
 (defun internal-face-interactive-stipple (what)