From: Mattias Engdegård <mattiase@acm.org>
Date: Wed, 4 Dec 2019 10:37:26 +0000 (+0100)
Subject: Don't use the return value of 'push'
X-Git-Tag: emacs-27.0.90~446
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f5672b24a8510ee5c62b9e366e4ab6b1fde5ed77;p=emacs.git

Don't use the return value of 'push'

Although 'push' returns the modified list, it isn't actually
documented to do so, so don't rely on it.

* lisp/emacs-lisp/rx.el (rx--translate-any): Add progn.
---

diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el
index 6fde27831a0..0dc6e198663 100644
--- a/lisp/emacs-lisp/rx.el
+++ b/lisp/emacs-lisp/rx.el
@@ -378,7 +378,7 @@ If NEGATED, negate the sense."
                   (let ((class (cdr (assq arg rx--char-classes))))
                     (and class
                          (or (memq class classes)
-                             (push class classes))))))
+                             (progn (push class classes) t))))))
             (t (error "Invalid rx `any' argument: %s" arg))))
     (let ((items
            ;; Translate strings and conses into nonoverlapping intervals,