From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 5 Apr 2011 20:26:55 +0000 (-0700)
Subject: * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
X-Git-Tag: emacs-pretest-24.0.90~104^2~275^2~394^2~3
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f390e2d53a670e4ebcb6b73f4baeaf792f46c112;p=emacs.git

* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 99cdde19234..282b41afd3c 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -2,6 +2,8 @@
 
 	Fix more problems found by GCC 4.6.0's static checks.
 
+	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
+
 	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
 
 	* fns.c (Fstring_to_unibyte): Don't rely on undefined behavior
diff --git a/src/xmenu.c b/src/xmenu.c
index 8ecef00c88e..6e175e69039 100644
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -341,7 +341,7 @@ for instance using the window manager, then this produces a quit and
     unbind_to (specpdl_count, Qnil);
     discard_menu_items ();
 
-    if (error_name) error (error_name);
+    if (error_name) error ("%s", error_name);
     return selection;
   }
 #endif