From: Eli Zaretskii <eliz@gnu.org>
Date: Fri, 29 Dec 2023 12:32:56 +0000 (+0200)
Subject: ; Fix style of comments and doc strings in last change in ses.el
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f27dd1f954bcc6f35f4248370a7fe09de5f66096;p=emacs.git

; Fix style of comments and doc strings in last change in ses.el

* lisp/ses.el (ses-cell-set-formula): Fix comments style.
(cl-member): Fix byte-compilation warning.

* test/lisp/ses-tests.el
(ses-set-formula-write-cells-with-changed-references): Doc fix.
---

diff --git a/lisp/ses.el b/lisp/ses.el
index b5193c3e4b8..618a85aab70 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -69,6 +69,8 @@
 (require 'macroexp)
 (eval-when-compile (require 'cl-lib))
 
+;; Autoloaded, but we have not loaded cl-loaddefs yet.
+(declare-function cl-member "cl-seq" (cl-item cl-list &rest cl-keys))
 
 ;;----------------------------------------------------------------------------
 ;; User-customizable variables
@@ -890,15 +892,15 @@ means Emacs will crash if FORMULA contains a circular list."
       ;;in the new list.
       (dolist (ref oldref)
 	(unless (memq ref newref)
-          ;; because we do not cancel edit when the user provides a
+          ;; Because we do not cancel edit when the user provides a
           ;; false reference in it, then we need to check that ref
           ;; points to a cell that is within the spreadsheet.
 	  (when
               (and (setq x (ses-sym-rowcol ref))
                    (< (setq xrow (car x)) ses--numrows)
                    (< (setq xcol (cdr x)) ses--numcols))
-            ;; cell ref has to be re-written to data area as its
-            ;; reference list is changed
+            ;; Cell reference has to be re-written to data area as its
+            ;; reference list is changed.
             (cl-pushnew x  ses--deferred-write  :test #'equal)
             (ses-set-cell xrow xcol 'references
                           (delq sym (ses-cell-references xrow xcol))))))
@@ -910,8 +912,8 @@ means Emacs will crash if FORMULA contains a circular list."
              (<  (setq xrow (car x)) ses--numrows)
              (<  (setq xcol (cdr x)) ses--numcols))
             (unless (memq sym (setq xref (ses-cell-references xrow xcol)))
-              ;; cell ref has to be re-written to data area as its
-              ;; reference list is changed
+              ;; Cell reference has to be re-written to data area as
+              ;; its reference list is changed.
               (cl-pushnew x  ses--deferred-write  :test #'equal)
               (ses-set-cell xrow xcol 'references (cons sym xref)))
           (cl-pushnew ref not-a-cell-ref-list)))
diff --git a/test/lisp/ses-tests.el b/test/lisp/ses-tests.el
index e2ff41c5875..265b448226f 100644
--- a/test/lisp/ses-tests.el
+++ b/test/lisp/ses-tests.el
@@ -242,8 +242,9 @@ to `ses--bar' and inserting a row, makes A2 value empty, and `ses--bar' equal to
       (should (eq (ses--cell-at-pos (point)) 'ses--toto)))))
 
 (ert-deftest ses-set-formula-write-cells-with-changed-references ()
-  "Fix of bug#5852. When setting a formula has some cell with
-changed references, this cell has to be rewritten to data area."
+  "Test fix of bug#5852.
+When setting a formula has some cell with changed references, this
+cell has to be rewritten to data area."
   (let ((ses-initial-size '(4 . 3))
         ses-after-entry-functions beg)
     (with-temp-buffer