From: Michael Albinus <michael.albinus@gmx.de>
Date: Wed, 24 Oct 2018 18:56:40 +0000 (+0200)
Subject: Fix Bug#33141
X-Git-Tag: emacs-27.0.90~4256
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f1f1687fcd8d48cd519c0f2977bcecbf394a7f01;p=emacs.git

Fix Bug#33141

* lisp/net/tramp.el (tramp-make-tramp-file-name): Avoid check for
empty method with simplified `tramp-syntax'.  (Bug#33141)
---

diff --git a/lisp/net/tramp-compat.el b/lisp/net/tramp-compat.el
index ec8e54509d1..15b5a4958c6 100644
--- a/lisp/net/tramp-compat.el
+++ b/lisp/net/tramp-compat.el
@@ -269,4 +269,7 @@ A nil value for either argument stands for the current time."
 
 ;;; TODO:
 
+;; * When we get rid of Emacs 24, replace "(mapconcat 'identity" by
+;;   "(string-join".
+
 ;;; tramp-compat.el ends here
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 2e6cdf999a5..a1246659d8d 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -1439,7 +1439,9 @@ the form (METHOD USER DOMAIN HOST PORT LOCALNAME &optional HOP)."
 	      localname (nth 5 args)
 	      hop (nth 6 args))))
 
-    (when (zerop (length method))
+    ;; Unless `tramp-syntax' is `simplified', we need a method.
+    (when (and (not (zerop (length tramp-postfix-method-format)))
+	       (zerop (length method)))
       (signal 'wrong-type-argument (list 'stringp method)))
     (concat tramp-prefix-format hop
 	    (unless (zerop (length tramp-postfix-method-format))