From: Stefan Kangas <stefan@marxist.se>
Date: Wed, 3 Nov 2021 06:14:21 +0000 (+0100)
Subject: image-dired: Improve marking behavior
X-Git-Tag: emacs-29.0.90~3671^2~271
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f1770a68aea960876ffcf2cf00be0272f3e39108;p=emacs.git

image-dired: Improve marking behavior

* lisp/image-dired.el (image-dired-thumb-mark): Use DarkOrange as
background to better match the 'dired-marked' face.
(image-dired-show-all-from-dir): Disable all marks when entering a
full directory.
(image-dired-unmark-all-marks): Add mode tag.
(image-dired-thumbnail-mode-map): Bind 'image-dired-unmark-all-marks'
to "U".
---

diff --git a/etc/NEWS b/etc/NEWS
index 211d943a149..11ff0ef7a83 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -244,8 +244,8 @@ external "exiftool" command to be available.  The user options
 
 ---
 *** New command for the thumbnail buffer.
-The new command 'image-dired-unmark-all-marks' has been added with a
-binding in the menu.
+The new command 'image-dired-unmark-all-marks' has been added.  It is
+bound to "U" in the thumbnail buffer.
 
 ---
 *** Support Thumbnail Managing Standard v0.9.0 (Dec 2020).
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 1e1c8f6c4c9..f5792096e19 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -465,10 +465,10 @@ images."
   :version "28.1")
 
 (defface image-dired-thumb-mark
-  '((t (:background "orange")))
+  '((t (:background "DarkOrange")))
   "Background-color for marked images in thumbnail buffer."
   :group 'image-dired
-  :version "28.1")
+  :version "29.1")
 
 (defcustom image-dired-line-up-method 'dynamic
   "Default method for line-up of thumbnails in thumbnail buffer.
@@ -1129,7 +1129,8 @@ never ask for confirmation."
                       "Directory contains more than %d image files.  Proceed?"
                       image-dired-show-all-from-dir-max-files))))
            (image-dired-display-thumbs)
-           (pop-to-buffer image-dired-thumbnail-buffer))
+           (pop-to-buffer image-dired-thumbnail-buffer)
+           (image-dired-unmark-all-marks))
           (t (message "Image-Dired canceled")))))
 
 ;;;###autoload
@@ -1539,9 +1540,9 @@ Should be called from commands in `image-dired-thumbnail-mode'."
       (dired-mark 1))))
 
 (defun image-dired-unmark-all-marks ()
-  "Remove all marks from all files.
-Do this in the Dired buffer and update this thumbnail buffer."
-  (interactive)
+  "Remove all marks from all files in associated Dired buffer.
+Also update the marks in the thumbnail buffer."
+  (interactive nil image-dired-thumbnail-mode)
   (with-current-buffer (image-dired-associated-dired-buffer)
     (dired-unmark-all-marks))
   (image-dired-thumb-update-marks))
@@ -1614,6 +1615,7 @@ You probably want to use this together with
     (define-key map [delete] 'image-dired-flag-thumb-original-file)
     (define-key map "m" 'image-dired-mark-thumb-original-file)
     (define-key map "u" 'image-dired-unmark-thumb-original-file)
+    (define-key map "U" 'image-dired-unmark-all-marks)
     (define-key map "." 'image-dired-track-original-file)
     (define-key map [tab] 'image-dired-jump-original-dired-buffer)