From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 21 Feb 2011 22:31:55 +0000 (-0800)
Subject: * movemail.c (popmail): Report fchown failure instead of ignoring it.
X-Git-Tag: emacs-pretest-24.0.90~104^2~275^2~777
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f0939c31a6f4f7afec3adf3f31817f998af6e667;p=emacs.git

* movemail.c (popmail): Report fchown failure instead of ignoring it.

But if the file already has the right ownership, don't worry about it.
---

diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog
index d865754cb40..e0a175e8167 100644
--- a/lib-src/ChangeLog
+++ b/lib-src/ChangeLog
@@ -1,5 +1,8 @@
 2011-02-21  Paul Eggert  <eggert@cs.ucla.edu>
 
+	* movemail.c (popmail): Report fchown failure instead of ignoring it.
+	But if the file already has the right ownership, don't worry about it.
+
 	* make-docfile.c (input_buffer): Rename variables to avoid shadowing.
 
 	* movemail.c (main, pop_retr): Rename locals to avoid shadowing.
diff --git a/lib-src/movemail.c b/lib-src/movemail.c
index a5084f27f22..bc7fa8824e2 100644
--- a/lib-src/movemail.c
+++ b/lib-src/movemail.c
@@ -723,7 +723,18 @@ popmail (char *mailbox, char *outfile, int preserve, char *password, int reverse
       error ("Error in open: %s, %s", strerror (errno), outfile);
       return EXIT_FAILURE;
     }
-  fchown (mbfi, getuid (), -1);
+
+  if (fchown (mbfi, getuid (), -1) != 0)
+    {
+      int fchown_errno = errno;
+      struct stat st;
+      if (fstat (mbfi, &st) != 0 || st.st_uid != getuid ())
+	{
+	  pop_close (server);
+	  error ("Error in fchown: %s, %s", strerror (fchown_errno), outfile);
+	  return EXIT_FAILURE;
+	}
+    }
 
   if ((mbf = fdopen (mbfi, "wb")) == NULL)
     {