From: Glenn Morris <rgm@gnu.org>
Date: Mon, 5 Mar 2018 18:36:05 +0000 (-0500)
Subject: ; Add fixme comments re password caching
X-Git-Tag: emacs-27.0.90~5552
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=f02ce3b1e41c735c3b1a0da4e45434c7b8313bde;p=emacs.git

; Add fixme comments re password caching
---

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 3855d7b7964..dc10763da86 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -647,6 +647,7 @@ The passphrase is read and cached."
       (when passphrase
 	(let ((password-cache-expiry (mml-secure-cache-expiry-interval
 				      (epg-context-protocol context))))
+	  ;; FIXME test passphrase works before caching it.
 	  (password-cache-add password-cache-key-id passphrase))
 	(mml-secure-add-secret-key-id password-cache-key-id)
 	(copy-sequence passphrase)))))
diff --git a/lisp/gnus/smime.el b/lisp/gnus/smime.el
index d55cea724fb..ab2a5b0f813 100644
--- a/lisp/gnus/smime.el
+++ b/lisp/gnus/smime.el
@@ -238,6 +238,7 @@ password under `cache-key'."
 	  "Passphrase for secret key (RET for no passphrase): " cache-key)))
     (if (string= passphrase "")
 	nil
+      ;; FIXME test passphrase works before caching it.
       (and passphrase cache-key (password-cache-add cache-key passphrase))
       passphrase)))
 
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 60112392537..fe9f1976944 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -4459,6 +4459,7 @@ Invokes `password-read' if available, `read-passwd' else."
 					  auth-passwd))))
 	       ;; Try the password cache.
 	       (let ((password (password-read pw-prompt key)))
+		 ;; FIXME test password works before caching it.
 		 (password-cache-add key password)
 		 password)
 	       ;; Else, get the password interactively.