From: Noam Postavsky <npostavs@users.sourceforge.net>
Date: Wed, 11 Apr 2018 22:05:27 +0000 (+0200)
Subject: Give better errors in signing failures in Gnus
X-Git-Tag: emacs-27.0.90~5298
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ef2059e877d104bfe5abd24df05bb09c7295e4fa;p=emacs.git

Give better errors in signing failures in Gnus

* lisp/gnus/mml1991.el (mml1991-epg-sign): Give better error
messages when signing fails (bug#26298).

* lisp/gnus/mml2015.el (mml2015-epg-sign): Ditto.
---

diff --git a/lisp/gnus/mml1991.el b/lisp/gnus/mml1991.el
index 93b1b5049a8..b2056b2fd0d 100644
--- a/lisp/gnus/mml1991.el
+++ b/lisp/gnus/mml1991.el
@@ -275,6 +275,8 @@ Whether the passphrase is cached at all is controlled by
 	(mm-decode-content-transfer-encoding cte)))
     (let* ((pair (mml-secure-epg-sign 'OpenPGP 'clear))
 	   (signature (car pair)))
+      (unless (stringp signature)
+        (error "Signature failed"))
       (delete-region (point-min) (point-max))
       (insert
        (with-temp-buffer
diff --git a/lisp/gnus/mml2015.el b/lisp/gnus/mml2015.el
index 5980ddb38fe..403b5e1af6a 100644
--- a/lisp/gnus/mml2015.el
+++ b/lisp/gnus/mml2015.el
@@ -958,6 +958,8 @@ If set, it overrides the setting of `mml2015-sign-with-sender'."
     (let* ((pair (mml-secure-epg-sign 'OpenPGP t))
 	   (signature (car pair))
 	   (micalg (cdr pair)))
+      (unless (stringp signature)
+        (error "Signature failed"))
       (goto-char (point-min))
       (insert (format "Content-Type: multipart/signed; boundary=\"%s\";\n"
 		      boundary))