From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri, 2 Nov 2018 19:00:34 +0000 (-0400)
Subject: * src/data.c (Ffset): Don't signal gratuitous errors
X-Git-Tag: emacs-27.0.90~4230
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ef183b996c3aade55e16d8fbcd68d9c4f360729e;p=emacs.git

* src/data.c (Ffset): Don't signal gratuitous errors
---

diff --git a/src/data.c b/src/data.c
index 538081e5c9b..f8b991e8981 100644
--- a/src/data.c
+++ b/src/data.c
@@ -758,7 +758,9 @@ DEFUN ("fset", Ffset, Sfset, 2, 2, 0,
   register Lisp_Object function;
   CHECK_SYMBOL (symbol);
   /* Perhaps not quite the right error signal, but seems good enough.  */
-  if (NILP (symbol))
+  if (NILP (symbol) && !NILP (definition))
+    /* There are so many other ways to shoot oneself in the foot, I don't
+       think this one little sanity check is worth its cost, but anyway.  */
     xsignal1 (Qsetting_constant, symbol);
 
   function = XSYMBOL (symbol)->u.s.function;