From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Mon, 1 Nov 2021 03:02:16 +0000 (+0100)
Subject: Fix infloop in help-make-xrefs in certain keymaps
X-Git-Tag: emacs-29.0.90~3671^2~308
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=eeb09ff41ba2f6b9a199ddd9de58191583eecd98;p=emacs.git

Fix infloop in help-make-xrefs in certain keymaps

* lisp/help-mode.el (help-make-xrefs): Adjust xref symbol finding
after changes to how keymaps are output.
---

diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 0f80c265733..67453453d3b 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -661,8 +661,9 @@ that."
                           (help-xref-button 3 'help-function symbol))
                         (forward-line)
                         ;; Skip empty line.
-                        (while (or (eolp)
-                                   (looking-at-p " *(this binding"))
+                        (while (and (not (eobp))
+                                    (or (eolp)
+                                        (looking-at-p " *(this binding")))
                           (forward-line)))))))
             (set-syntax-table stab))
           ;; Delete extraneous newlines at the end of the docstring