From: Mattias Engdegård <mattiase@acm.org>
Date: Mon, 3 Jun 2024 14:52:27 +0000 (+0200)
Subject: ; compilation-error-regexp-alist-alist order comment
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ee47beaee27e3cbd868010ae97043fcb448a30d8;p=emacs.git

; compilation-error-regexp-alist-alist order comment

(cherry picked from commit 876bd6506d78392d7f6b8d13df678da21ad05af9)
---

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 0dda610776e..91d256a1dcd 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -194,6 +194,11 @@ and a string describing how the process finished.")
 
 (defvar compilation-error-regexp-alist-alist
  (eval-when-compile
+   ;; The order of this list is the default order of items in
+   ;; `compilation-error-regexp-alist' which is also the matching order,
+   ;; so don't add things in alphabetic order just out of habit.
+   ;; FIXME: We should sort it by frequency (less often used ones in the back),
+   ;; but individual patterns also have their own partial order.
   `((absoft
      "^\\(?:[Ee]rror on \\|[Ww]arning on\\( \\)\\)?[Ll]ine[ \t]+\\([0-9]+\\)[ \t]+\
 of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))