From: Eli Zaretskii <eliz@gnu.org>
Date: Wed, 3 Jul 2019 07:31:48 +0000 (+0300)
Subject: Fix rotation validity test in image.c
X-Git-Tag: emacs-27.0.90~2112
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ecd7d40a3be0b3b51743fc2c2e98dd14c6faca84;p=emacs.git

Fix rotation validity test in image.c

* src/image.c (compute_image_rotation): Fix the validity test
for :rotation values.  This avoids logging error messages when
no :rotation was provided in the image spec.
---

diff --git a/src/image.c b/src/image.c
index d44a9d3dc27..6ead12166b6 100644
--- a/src/image.c
+++ b/src/image.c
@@ -2065,7 +2065,10 @@ matrix3x3_mult (matrix3x3 a, matrix3x3 b, matrix3x3 result)
 static void
 compute_image_rotation (struct image *img, double *rotation)
 {
-  Lisp_Object value = image_spec_value (img->spec, QCrotation, NULL);
+  bool foundp = false;
+  Lisp_Object value = image_spec_value (img->spec, QCrotation, &foundp);
+  if (!foundp)
+    return;
   if (! NUMBERP (value))
     {
       image_error ("Invalid image `:rotation' parameter");