From: Paul Eggert Date: Sun, 19 Jun 2011 00:06:17 +0000 (-0700) Subject: * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). X-Git-Tag: emacs-pretest-24.0.90~104^2~473^2~40 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=eb49b13608d6cf06af52c7d9fe88928a48f48cee;p=emacs.git * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). This didn't break anything, but it didn't help either. It's confusing to put a bogus integer in a place where the actual value does not matter. --- diff --git a/src/ChangeLog b/src/ChangeLog index aa0a0a39bb8..1b4edb91d1a 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,10 @@ +2011-06-19 Paul Eggert + + * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). + This didn't break anything, but it didn't help either. + It's confusing to put a bogus integer in a place where the actual + value does not matter. + 2011-06-18 Paul Eggert * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT. diff --git a/src/lisp.h b/src/lisp.h index 2dcf73b7506..e065bad10d0 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -1890,7 +1890,7 @@ typedef struct { #define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ Lisp_Object fnname DEFUN_ARGS_ ## maxargs ; \ static DECL_ALIGN (struct Lisp_Subr, sname) = \ - { PVEC_SUBR | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)), \ + { PVEC_SUBR, \ { .a ## maxargs = fnname }, \ minargs, maxargs, lname, intspec, 0}; \ Lisp_Object fnname