From: Mattias Engdegård <mattiase@acm.org>
Date: Wed, 31 Aug 2022 12:31:31 +0000 (+0200)
Subject: Better `take` and `ntake` bignum argument handling
X-Git-Tag: emacs-29.0.90~1856^2~808
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=e7193902b23deb842f55c1cd9100b807e199f4bd;p=emacs.git

Better `take` and `ntake` bignum argument handling

* src/fns.c (Ftake, Fntake): Treat positive bignum arguments
as most-positive-fixnum which results in better error checking
of improper lists.
---

diff --git a/src/fns.c b/src/fns.c
index 07102256fed..2f4808be3d0 100644
--- a/src/fns.c
+++ b/src/fns.c
@@ -1563,18 +1563,21 @@ If N is zero or negative, return nil.
 If N is greater or equal to the length of LIST, return LIST (or a copy).  */)
   (Lisp_Object n, Lisp_Object list)
 {
-  if (BIGNUMP (n))
+  EMACS_INT m;
+  if (FIXNUMP (n))
+    {
+      m = XFIXNUM (n);
+      if (m <= 0)
+	return Qnil;
+    }
+  else if (BIGNUMP (n))
     {
       if (mpz_sgn (*xbignum_val (n)) < 0)
 	return Qnil;
-      CHECK_LIST (list);
-      return list;
+      m = MOST_POSITIVE_FIXNUM;
     }
-  if (!FIXNUMP (n))
+  else
     wrong_type_argument (Qintegerp, n);
-  EMACS_INT m = XFIXNUM (n);
-  if (m <= 0)
-    return Qnil;
   CHECK_LIST (list);
   if (NILP (list))
     return Qnil;
@@ -1602,18 +1605,21 @@ If N is greater or equal to the length of LIST, return LIST unmodified.
 Otherwise, return LIST after truncating it.  */)
   (Lisp_Object n, Lisp_Object list)
 {
-  if (BIGNUMP (n))
+  EMACS_INT m;
+  if (FIXNUMP (n))
+    {
+      m = XFIXNUM (n);
+      if (m <= 0)
+	return Qnil;
+    }
+  else if (BIGNUMP (n))
     {
       if (mpz_sgn (*xbignum_val (n)) < 0)
 	return Qnil;
-      CHECK_LIST (list);
-      return list;
+      m = MOST_POSITIVE_FIXNUM;
     }
-  if (!FIXNUMP (n))
+  else
     wrong_type_argument (Qintegerp, n);
-  EMACS_INT m = XFIXNUM (n);
-  if (m <= 0)
-    return Qnil;
   CHECK_LIST (list);
   Lisp_Object tail = list;
   --m;