From: João Távora <joaotavora@gmail.com>
Date: Sun, 15 Aug 2021 08:12:23 +0000 (+0100)
Subject: Fix bug#50063 when using icomplete-fido-kill with C-x p p
X-Git-Tag: emacs-28.0.90~1499
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=e6f3a4dc6cd4ffca9b8b2ea0c9271f832df07e3e;p=emacs.git

Fix bug#50063 when using icomplete-fido-kill with C-x p p

C-x p p utilizes a completion table "category" which is 'project-file'
icomplete-fido-kill only functioned for 'buffer' and 'file', and
failed with a non-informative message when something else was used.

* lisp/icomplete.el (icomplete-fido-kill): Support 'project-file'
class.  Use cl-case, instead of pcase.
---

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index adea1505fd2..cd1979d04ad 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -298,18 +298,21 @@ require user confirmation."
         (call-interactively 'kill-line)
       (let* ((all (completion-all-sorted-completions))
              (thing (car all))
+             (cat (icomplete--category))
              (action
-              (pcase (icomplete--category)
-                (`buffer
+              (cl-case cat
+                (buffer
                  (lambda ()
                    (when (yes-or-no-p (concat "Kill buffer " thing "? "))
                      (kill-buffer thing))))
-                (`file
+                ((project-file file)
                  (lambda ()
                    (let* ((dir (file-name-directory (icomplete--field-string)))
                           (path (expand-file-name thing dir)))
                      (when (yes-or-no-p (concat "Delete file " path "? "))
-                       (delete-file path) t)))))))
+                       (delete-file path) t))))
+                (t
+                 (error "Sorry, don't know how to kill things for `%s'" cat)))))
         (when (let (;; Allow `yes-or-no-p' to work and don't let it
                     ;; `icomplete-exhibit' anything.
                     (enable-recursive-minibuffers t)