From: Stefan Kangas <stefan@marxist.se>
Date: Sun, 7 Aug 2022 12:19:19 +0000 (+0200)
Subject: ; Improve obsoletions in ediff-init.el
X-Git-Tag: emacs-29.0.90~1447^2~338
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=e672cad231f4be2e5456e2bf6550a8523a3c24ed;p=emacs.git

; Improve obsoletions in ediff-init.el

* lisp/vc/ediff-init.el (ediff-convert-standard-filename): Convert
to obsolete function alias.
(ediff-device-type, ediff-last-command-char): Better document
obsoletion.
---

diff --git a/lisp/vc/ediff-init.el b/lisp/vc/ediff-init.el
index e83a172cb84..6e0656ab4e2 100644
--- a/lisp/vc/ediff-init.el
+++ b/lisp/vc/ediff-init.el
@@ -44,9 +44,8 @@
 This is provided as a temporary relief for users of face-capable displays
 that Ediff doesn't know about.")
 
-;; Are we running as a window application or on a TTY?
 (defsubst ediff-device-type ()
-  (declare (obsolete nil "27.1"))
+  (declare (obsolete window-system "27.1"))
   window-system)
 
 (defun ediff-window-display-p ()
@@ -1381,7 +1380,7 @@ This default should work without changes."
 (define-obsolete-function-alias 'ediff-event-key #'identity "27.1")
 
 (defun ediff-last-command-char ()
-  (declare (obsolete nil "27.1"))
+  (declare (obsolete last-command-event "27.1"))
   last-command-event)
 
 
@@ -1562,15 +1561,8 @@ This default should work without changes."
   (ediff-file-attributes filename 5))
 
 
-;;; Obsolete
-
-(defun ediff-convert-standard-filename (fname)
-  (declare (obsolete convert-standard-filename "28.1"))
-  (convert-standard-filename fname))
-
-(define-obsolete-function-alias 'ediff-with-syntax-table
-  #'with-syntax-table "27.1")
-
+(define-obsolete-function-alias 'ediff-with-syntax-table #'with-syntax-table "27.1")
+(define-obsolete-function-alias 'ediff-convert-standard-filename #'convert-standard-filename "28.1")
 (define-obsolete-function-alias 'ediff-hide-face #'ignore "28.1")
 
 (provide 'ediff-init)