From: Basil L. Contovounesios <contovob@tcd.ie>
Date: Tue, 9 Apr 2019 15:32:27 +0000 (+0100)
Subject: ; Warn of while/dolist pitfall in gnus-sum.el
X-Git-Tag: emacs-27.0.90~3261^2~27
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=e1a457e63530cd566a1bc2957b70221bb6f76984;p=emacs.git

; Warn of while/dolist pitfall in gnus-sum.el

Suggested by Andy Moreton in the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-04/msg00294.html
* lisp/gnus/gnus-sum.el (gnus-summary-move-article): Add comment
warning of common while/dolist pitfall. (bug#33653#134)
---

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 8959a2b3d0a..b8aa302f11a 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -10088,6 +10088,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'."
 		  (or (car select-method)
 		      (gnus-group-decoded-name to-newsgroup))
 		  articles)
+    ;; This `while' is not equivalent to a `dolist' (bug#33653#134).
     (while articles
       (setq article (pop articles))
       ;; Set any marks that may have changed in the summary buffer.