From: João Távora <joaotavora@gmail.com>
Date: Fri, 27 Oct 2023 16:28:36 +0000 (+0100)
Subject: Revert "Fix performance regression in completion-pcm--all-completions"
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=d91085807cc16867f4bd9400dae63bef12f1bb2d;p=emacs.git

Revert "Fix performance regression in completion-pcm--all-completions"

The performance optimization introduces problems and isn't worth it.

bug#48841, bug#47711

This reverts commit 54a6079ba4c94ba6d8b56987400feeabe0c77955.
---

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index c32bcee51ed..b38eb49aba8 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -3738,9 +3738,10 @@ PATTERN is as returned by `completion-pcm--string->pattern'."
             (t
              ;; The pattern has something interesting to match, in
              ;; which case we take the opportunity to add an early
-             ;; `completion-score' cookie to each completion.
+             ;; completion-score cookie to each completion.
              (cl-loop with re = (completion-pcm--pattern->regex pattern 'group)
-                      for comp in completions
+                      for orig in completions
+                      for comp = (copy-sequence orig)
                       for score = (completion--flex-score comp re t)
                       when score
                       do (put-text-property 0 1 'completion-score