From: Stephen Gildea <stepheng+emacs@gildea.com>
Date: Tue, 5 Oct 2021 16:15:57 +0000 (-0700)
Subject: native-comp-available-p is the definitive test
X-Git-Tag: emacs-28.0.90~389
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=d86b2e59c746966e1ae023937b2a6b3b8c16d18b;p=emacs.git

native-comp-available-p is the definitive test

* doc/lispref/compile.texi (Native Compilation): Document
native-comp-available-p as the way to test for native compilation.
* lisp/emacs-lisp/package.el (package--native-compile-async):
* test/lisp/mh-e/mh-utils-tests.el (mh-ensure-native-trampolines):
Test for native compilation with native-comp-available-p.

Thank you to Andrea Corallo for reviewing this patch.
---

diff --git a/doc/lispref/compile.texi b/doc/lispref/compile.texi
index 15d1f4ce53a..523758c10f5 100644
--- a/doc/lispref/compile.texi
+++ b/doc/lispref/compile.texi
@@ -811,8 +811,7 @@ for you to be able to native-compile Lisp code.
 
 @vindex native-compile@r{, a Lisp feature}
   To determine whether the current Emacs process can produce and load
-natively-compiled Lisp code, test whether the @code{native-compile}
-feature is available (@pxref{Named Features}).  Alternatively, call
+natively-compiled Lisp code, call
 @code{native-comp-available-p} (@pxref{Native-Compilation Functions}).
 
   Unlike byte-compiled code, natively-compiled Lisp code is executed
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 62f5fc73417..5445fa970f8 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1081,8 +1081,7 @@ This assumes that `pkg-desc' has already been activated with
   "Native compile installed package PKG-DESC asynchronously.
 This assumes that `pkg-desc' has already been activated with
 `package-activate-1'."
-  (when (and (featurep 'native-compile)
-             (native-comp-available-p))
+  (when (native-comp-available-p)
     (let ((warning-minimum-level :error))
       (native-compile-async (package-desc-dir pkg-desc) t))))
 
diff --git a/test/lisp/mh-e/mh-utils-tests.el b/test/lisp/mh-e/mh-utils-tests.el
index 82afbab6474..f1282ab44a6 100644
--- a/test/lisp/mh-e/mh-utils-tests.el
+++ b/test/lisp/mh-e/mh-utils-tests.el
@@ -113,7 +113,7 @@ As `call-process'' and `file-directory-p' will be redefined, the
 native compiler will invoke `call-process' to compile the
 respective trampolines.  To avoid interferences with the
 `call-process' mocking we build these AOT."
-  (when (featurep 'native-compile)
+  (when (native-comp-available-p)
     (mapc #'comp-subr-trampoline-install '(call-process file-directory-p))))
 
 (defun mh-test-utils-setup-with-mocks ()