From: Paul Eggert Date: Fri, 26 Jul 2013 08:39:55 +0000 (+0100) Subject: Fix minor problems found by static checking. X-Git-Tag: emacs-24.3.90~173^2^2~42^2~45^2~387^2~1698^2~37 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=d5a7a9d94b84c99bc0a7178002d83ea7754732c0;p=emacs.git Fix minor problems found by static checking. * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static. (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC. --- diff --git a/src/ChangeLog b/src/ChangeLog index 6542703adbb..2b105e2405e 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,9 @@ +2013-07-26 Paul Eggert + + Fix minor problems found by static checking. + * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static. + (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC. + 2013-07-26 Stefan Monnier * eval.c (set_specpdl_old_value): New function. diff --git a/src/eval.c b/src/eval.c index e55a3b259e0..bb5d5efc9ba 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3424,7 +3424,7 @@ Output stream used is value of `standard-output'. */) return Qnil; } -union specbinding * +static union specbinding * get_backtrace_frame (Lisp_Object nframes, Lisp_Object base) { union specbinding *pdl = backtrace_top (); @@ -3483,7 +3483,7 @@ nearest activation frame. */) pointer-reversal trick. As it turns out, the rewind does the same as the unwind, except it starts from the other end of the spepdl stack, so we use the same function for both unwind and rewind. */ -void +static void backtrace_eval_unrewind (int distance) { union specbinding *tmp = specpdl_ptr; @@ -3524,10 +3524,11 @@ backtrace_eval_unrewind (int distance) break; } else - /* FALLTHROUGH! - NOTE: we only ever come here if make_local_foo was used for - the first time on this var within this let. */ - ; + { + /* FALLTHROUGH! + NOTE: we only ever come here if make_local_foo was used for + the first time on this var within this let. */ + } case SPECPDL_LET_DEFAULT: { Lisp_Object sym = specpdl_symbol (tmp);