From: Po Lu <luangruo@yahoo.com>
Date: Mon, 3 Jun 2024 12:37:41 +0000 (+0800)
Subject: Small followup change
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=d404dc4ce12d641d742fdf404af43a86ebdc10bc;p=emacs.git

Small followup change

* lisp/image.el (create-image): Remove supererogatory instances
of pcase.  Recognize new `lambda' values and refrain from
specifying a default transform-smoothing when it is returned.
(image--default-smoothing): Return lambda if scaling is default.

* lisp/tool-bar.el (tool-bar--image-expression): Revert this
portion of last change.

(cherry picked from commit 68cc4cb6b1ce7ccc66084cb5e431bc9f6713bf04)
---

diff --git a/lisp/image.el b/lisp/image.el
index 654a15ef2b4..c155cda125e 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -520,7 +520,7 @@ Images should not be larger than specified by `max-image-size'."
   (let ((data-format
          ;; Pass the image format, if any, if this is data.
          (and data-p (or (plist-get props :format) t))))
-    ;; It is x_find_image_file in image.c that sets the search path.
+    ;; It is `x_find_image_fd' in image.c that sets the search path.
     (setq type (ignore-error unknown-image-type
                  (image-type file-or-data type data-format)))
     ;; If we have external image conversion switched on (for exotic,
@@ -540,12 +540,13 @@ Images should not be larger than specified by `max-image-size'."
 	           props)))
       ;; Add default smoothing.
       (unless (plist-member props :transform-smoothing)
-        (setq image (nconc image
-                           (list :transform-smoothing
-                                 (pcase image-transform-smoothing
-                                   ('t t)
-                                   ('nil nil)
-                                   (func (funcall func image)))))))
+        (let* ((func image-transform-smoothing)
+               (value (or (eq func t)
+                          (and func (funcall func image)))))
+          (unless (eq value 'lambda)
+            (setq image (nconc image
+                               (list :transform-smoothing
+                                     value))))))
       ;; Add original map from map.
       (when (and (plist-get props :map)
                  (not (plist-get props :original-map)))
@@ -559,13 +560,18 @@ Images should not be larger than specified by `max-image-size'."
       image)))
 
 (defun image--default-smoothing (image)
-  "Say whether IMAGE should be smoothed when transformed."
+  "Say whether IMAGE should be smoothed when transformed.
+Return `lambda' if the decision should be deferred to the time IMAGE is
+loaded."
   (let* ((props (nthcdr 5 image))
          (scaling (plist-get props :scale))
          (rotation (plist-get props :rotation)))
     (cond
+     ;; The scale of the image won't be available until
+     ;; `image_set_transform', and as such, defer to its judgement.
+     ((eq scaling 'default) 'lambda)
      ;; We always smooth when scaling down and small upwards scaling.
-     ((and scaling (numberp scaling) (< scaling 2))
+     ((and scaling (< scaling 2))
       t)
      ;; Smooth when doing non-90-degree rotation
      ((and rotation
diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el
index 1beb6dd819f..01c65c42324 100644
--- a/lisp/tool-bar.el
+++ b/lisp/tool-bar.el
@@ -220,8 +220,7 @@ To define items in any other map, use `tool-bar-local-item'."
   (let* ((fg (face-attribute 'tool-bar :foreground))
 	 (bg (face-attribute 'tool-bar :background))
 	 (colors (nconc (if (eq fg 'unspecified) nil (list :foreground fg))
-			(if (eq bg 'unspecified) nil (list :background bg))
-                        '(:transform-smoothing nil)))
+			(if (eq bg 'unspecified) nil (list :background bg))))
 	 (xpm-spec (list :type 'xpm :file (concat icon ".xpm")))
 	 (xpm-lo-spec (list :type 'xpm :file
 			    (concat "low-color/" icon ".xpm")))