From: Glenn Morris Date: Thu, 11 Jul 2013 16:04:56 +0000 (-0700) Subject: Quieten ruby-mode-tests.el compilation X-Git-Tag: emacs-24.3.90~173^2^2~42^2~45^2~387^2~1839 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=d2e1542aa91472925f13880b35d23ec5b5bbf9dd;p=emacs.git Quieten ruby-mode-tests.el compilation * test/automated/ruby-mode-tests.el (ruby-deftest-move-to-block): Goto point-min. (works-on-do, zero-is-noop, ok-with-three, ok-with-minus-two) (ruby-move-to-block-skips-percent-literal) (ruby-move-to-block-skips-heredoc) (ruby-move-to-block-moves-from-else-to-if) (ruby-beginning-of-defun-does-not-fold-case) (ruby-end-of-defun-skips-to-next-line-after-the-method): Replace goto-line with forward-line/goto-char. (ruby-move-to-block-does-not-fold-case): Remove unneeded end-of-buffer. --- diff --git a/test/ChangeLog b/test/ChangeLog index 5d51a8b7e98..29aa736e8ab 100644 --- a/test/ChangeLog +++ b/test/ChangeLog @@ -1,5 +1,16 @@ 2013-07-11 Glenn Morris + * automated/ruby-mode-tests.el (ruby-deftest-move-to-block): + Goto point-min. + (works-on-do, zero-is-noop, ok-with-three, ok-with-minus-two) + (ruby-move-to-block-skips-percent-literal) + (ruby-move-to-block-skips-heredoc) + (ruby-move-to-block-moves-from-else-to-if) + (ruby-beginning-of-defun-does-not-fold-case) + (ruby-end-of-defun-skips-to-next-line-after-the-method): + Replace goto-line with forward-line/goto-char. + (ruby-move-to-block-does-not-fold-case): Remove unneeded end-of-buffer. + * automated/package-test.el (makeinfo-buffer): Autoload. (compilation-in-progress, tar-parse-info, tar-header-name): Declare. (package-test-install-texinfo): Don't require makeinfo. diff --git a/test/automated/ruby-mode-tests.el b/test/automated/ruby-mode-tests.el index 3295684dd12..ad805f16777 100644 --- a/test/automated/ruby-mode-tests.el +++ b/test/automated/ruby-mode-tests.el @@ -475,29 +475,30 @@ VALUES-PLIST is a list with alternating index and value elements." (with-temp-buffer (insert ruby-block-test-example) (ruby-mode) + (goto-char (point-min)) ,@body))) (put 'ruby-deftest-move-to-block 'lisp-indent-function 'defun) (ruby-deftest-move-to-block works-on-do - (goto-line 11) + (forward-line 10) (ruby-end-of-block) (should (= 13 (line-number-at-pos))) (ruby-beginning-of-block) (should (= 11 (line-number-at-pos)))) (ruby-deftest-move-to-block zero-is-noop - (goto-line 5) + (forward-line 4) (ruby-move-to-block 0) (should (= 5 (line-number-at-pos)))) (ruby-deftest-move-to-block ok-with-three - (goto-line 2) + (forward-line 1) (ruby-move-to-block 3) (should (= 14 (line-number-at-pos)))) (ruby-deftest-move-to-block ok-with-minus-two - (goto-line 10) + (forward-line 9) (ruby-move-to-block -2) (should (= 2 (line-number-at-pos)))) @@ -515,7 +516,7 @@ VALUES-PLIST is a list with alternating index and value elements." | | |end"))) (ruby-with-temp-buffer s - (goto-line 1) + (goto-char (point-min)) (ruby-end-of-block) (should (= 5 (line-number-at-pos))) (ruby-beginning-of-block) @@ -530,7 +531,7 @@ VALUES-PLIST is a list with alternating index and value elements." | end | eowarn |end") - (goto-line 1) + (goto-char (point-min)) (ruby-end-of-block) (should (= 6 (line-number-at-pos))) (ruby-beginning-of-block) @@ -542,7 +543,6 @@ VALUES-PLIST is a list with alternating index and value elements." "foo do | Module.to_s |end") - (end-of-buffer) (let ((case-fold-search t)) (ruby-beginning-of-block)) (should (= 1 (line-number-at-pos))))) @@ -554,7 +554,8 @@ VALUES-PLIST is a list with alternating index and value elements." | end |else |end") - (goto-line 4) + (goto-char (point-min)) + (forward-line 3) (ruby-beginning-of-block) (should (= 1 (line-number-at-pos))))) @@ -566,7 +567,8 @@ VALUES-PLIST is a list with alternating index and value elements." | Class.to_s | end |end") - (goto-line 4) + (goto-char (point-min)) + (forward-line 3) (let ((case-fold-search t)) (beginning-of-defun)) (should (= 2 (line-number-at-pos))))) @@ -579,7 +581,8 @@ VALUES-PLIST is a list with alternating index and value elements." | 'ho hum' | end |end") - (goto-line 2) + (goto-char (point-min)) + (forward-line 1) (end-of-defun) (should (= 5 (line-number-at-pos)))))