From: Tom Tromey <tom@tromey.com>
Date: Sun, 8 Jul 2018 06:10:54 +0000 (-0600)
Subject: Make logb handle bignums
X-Git-Tag: emacs-27.0.90~4598^2~21
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=cca0e79ea81712786f92a6668c61001e60d24f32;p=emacs.git

Make logb handle bignums

* src/floatfns.c (Flogb): Handle bignums.
* test/src/floatfns-tests.el (bignum-logb): New test.
---

diff --git a/src/floatfns.c b/src/floatfns.c
index 6d7fc1452d3..9a5f0a3ad2f 100644
--- a/src/floatfns.c
+++ b/src/floatfns.c
@@ -328,7 +328,7 @@ This is the same as the exponent of a float.  */)
   (Lisp_Object arg)
 {
   EMACS_INT value;
-  CHECK_FIXNUM_OR_FLOAT (arg);
+  CHECK_NUMBER (arg);
 
   if (FLOATP (arg))
     {
@@ -345,8 +345,11 @@ This is the same as the exponent of a float.  */)
       else
 	value = MOST_POSITIVE_FIXNUM;
     }
+  else if (BIGNUMP (arg))
+    value = mpz_sizeinbase (XBIGNUM (arg)->value, 2) - 1;
   else
     {
+      eassert (FIXNUMP (arg));
       EMACS_INT i = eabs (XINT (arg));
       value = (i == 0
 	       ? MOST_NEGATIVE_FIXNUM
diff --git a/test/src/floatfns-tests.el b/test/src/floatfns-tests.el
index 0911ff46515..7714c05d60a 100644
--- a/test/src/floatfns-tests.el
+++ b/test/src/floatfns-tests.el
@@ -42,4 +42,8 @@
   (should (= most-positive-fixnum
              (- (abs most-negative-fixnum) 1))))
 
+(ert-deftest bignum-logb ()
+  (should (= (+ (logb most-positive-fixnum) 1)
+             (logb (+ most-positive-fixnum 1)))))
+
 (provide 'floatfns-tests)