From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Thu, 7 Oct 2021 16:49:36 +0000 (+0200)
Subject: Make gnus-define-keys obsolete
X-Git-Tag: emacs-29.0.90~3671^2~621^2~23
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=cb86d1d0def61950a149445cbbde829a30e210c4;p=emacs.git

Make gnus-define-keys obsolete

* lisp/gnus/gnus-util.el (gnus-define-keys):
(gnus-define-keys-1): Make obsolete.
---

diff --git a/etc/NEWS b/etc/NEWS
index 7b218aaf6da..ab15b1efaf0 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -117,6 +117,10 @@ Emacs buffers, like indentation and the like.  The new ert function
 
 * Incompatible Lisp Changes in Emacs 29.1
 
+---
+** 'gnus-define-keys' is now obsolete.
+Use 'define-keymap' instead.
+
 ---
 ** MozRepl has been removed from js.el.
 MozRepl was removed from Firefox in 2017, so this code doesn't work
diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el
index 0163abad4b1..a777157f894 100644
--- a/lisp/gnus/gnus-util.el
+++ b/lisp/gnus/gnus-util.el
@@ -305,7 +305,7 @@ Symbols are also allowed; their print names are used instead."
 
 (defmacro gnus-define-keys (keymap &rest plist)
   "Define all keys in PLIST in KEYMAP."
-  (declare (indent 1))
+  (declare (obsolete define-keymap "29.1") (indent 1))
   `(gnus-define-keys-1 ,(if (symbolp keymap) keymap `',keymap) (quote ,plist)))
 
 (defmacro gnus-define-keys-safe (keymap &rest plist)
@@ -319,6 +319,7 @@ Symbols are also allowed; their print names are used instead."
   `(gnus-define-keys-1 ,keymap (quote ,plist)))
 
 (defun gnus-define-keys-1 (keymap plist &optional safe)
+  (declare (obsolete define-keymap "29.1"))
   (when (null keymap)
     (error "Can't set keys in a null keymap"))
   (cond ((symbolp keymap) (error "First arg should be a keymap object"))