From: João Távora <joaotavora@gmail.com>
Date: Thu, 9 May 2019 18:49:31 +0000 (+0100)
Subject: Fix case when eglot-put-doc-in-help-buffer is nil
X-Git-Tag: emacs-29.0.90~1616^2~524^2~4^2~328
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=c90f33dc212259220aea1cd9edf73cf1fe2c0826;p=emacs.git

Fix case when eglot-put-doc-in-help-buffer is nil

* eglot.el (eglot--eldoc-message): Check eglot-put-doc-in-help-buffer.

GitHub-reference: fix https://github.com/joaotavora/eglot/issues/263
---

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index f5d81e4aa4c..b9fc25c01e3 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2075,7 +2075,8 @@ Buffer is displayed with `display-buffer', which obeys
   (when format
     (let ((string (apply #'format format args))) ;; FIXME: overworking?
       (when (or (eq t eglot-put-doc-in-help-buffer)
-                (funcall eglot-put-doc-in-help-buffer string))
+                (and eglot-put-doc-in-help-buffer
+                     (funcall eglot-put-doc-in-help-buffer string)))
         (with-current-buffer (eglot--help-buffer)
           (rename-buffer (format "*eglot-help for %s*" eglot--eldoc-hint))
           (let ((inhibit-read-only t))