From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Sun, 9 Feb 2014 06:32:30 +0000 (-0800)
Subject: * cmds.c (Fself_insert_command): Output a clearer error message on negative repetitions.
X-Git-Tag: emacs-24.3.90~173^2^2~42^2~45^2~60
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=c838bca91db36b3b8ad2405ecb8fff316313e71d;p=emacs.git

* cmds.c (Fself_insert_command): Output a clearer error message on negative repetitions.

Fixes: debbugs:9476
---

diff --git a/src/ChangeLog b/src/ChangeLog
index db24d8c947f..399138a1d80 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,8 @@
 2014-02-09  Lars Ingebrigtsen  <larsi@gnus.org>
 
+	* cmds.c (Fself_insert_command): Output a clearer error message on
+	negative repetitions (bug#9476).
+
 	* macros.c (Fexecute_kbd_macro): Doc fix (bug#14206).
 
 2014-02-08  Lars Ingebrigtsen  <larsi@gnus.org>
diff --git a/src/cmds.c b/src/cmds.c
index 8d61c19fb3c..29c574abb14 100644
--- a/src/cmds.c
+++ b/src/cmds.c
@@ -268,6 +268,7 @@ static int nonundocount;
 DEFUN ("self-insert-command", Fself_insert_command, Sself_insert_command, 1, 1, "p",
        doc: /* Insert the character you type.
 Whichever character you type to run this command is inserted.
+The numeric prefix argument N says how many times to repeat the insertion.
 Before insertion, `expand-abbrev' is executed if the inserted character does
 not have word syntax and the previous character in the buffer does.
 After insertion, the value of `auto-fill-function' is called if the
@@ -276,7 +277,11 @@ At the end, it runs `post-self-insert-hook'.  */)
   (Lisp_Object n)
 {
   bool remove_boundary = 1;
-  CHECK_NATNUM (n);
+  CHECK_NUMBER (n);
+
+  if (XFASTINT (n) < 1)
+    error ("Repetition argument is %d, but must be higher than 0.",
+	   XFASTINT (n));
 
   if (!EQ (Vthis_command, KVAR (current_kboard, Vlast_command)))
     nonundocount = 0;