From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Mon, 21 Mar 2022 14:53:25 +0000 (+0100)
Subject: Add notes about command modes and nativecomp interaction
X-Git-Tag: emacs-28.1~10
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=c69a6177422d52cb75f295ddf3ca29cd50337995;p=emacs.git

Add notes about command modes and nativecomp interaction

* doc/lispref/commands.texi (Command Modes): Note interaction with
native-compile (bug#54437).

* src/data.c: Add comment about not being supported.

Do not merge to master.
---

diff --git a/doc/lispref/commands.texi b/doc/lispref/commands.texi
index 0d13408e3f8..d948af6b4f1 100644
--- a/doc/lispref/commands.texi
+++ b/doc/lispref/commands.texi
@@ -682,6 +682,11 @@ different ways (e.g., @code{eww-open-in-new-buffer} and
 mode-specific, as they can be issued by the user from pretty much any
 context.
 
+Note that specifying command modes is not supported in native-compiled
+functions in Emacs 28.1 (but this is fixed in later Emacs versions).
+This means that @code{read-extended-command-predicate} isn't supported
+in native-compile builds, either.
+
 @node Generic Commands
 @subsection Select among Command Alternatives
 @cindex generic commands
diff --git a/src/data.c b/src/data.c
index 9bf9d605cf1..57205d88081 100644
--- a/src/data.c
+++ b/src/data.c
@@ -1022,6 +1022,9 @@ Value, if non-nil, is a list (interactive SPEC).  */)
   return Qnil;
 }
 
+/* Note that this doesn't work for native-compiled functions in Emacs
+   28.1, but it's fixed in later Emacs versions. */
+
 DEFUN ("command-modes", Fcommand_modes, Scommand_modes, 1, 1, 0,
        doc: /* Return the modes COMMAND is defined for.
 If COMMAND is not a command, the return value is nil.