From: João Távora <joaotavora@gmail.com>
Date: Sat, 10 Apr 2021 10:19:26 +0000 (+0100)
Subject: Fail earlier if stale Flymake report functions called
X-Git-Tag: emacs-28.0.90~2946
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=c50b5907e0113f7dbb2cc501c54dc365fd01a12b;p=emacs.git

Fail earlier if stale Flymake report functions called

If a Flymake backend calls a "stale" report function,
flymake--handle-report might be called for a backend function that is
no longer in the flymake--backend-state hash table.  This patch makes
that erroneous situation slightly more explicit.

* lisp/progmodes/flymake.el (flymake--handle-report): Improve
error reporting.
---

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 8481a27775f..e10602ab081 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -741,7 +741,10 @@ to handle a report even if TOKEN was not expected.  REGION is
 a (BEG . END) pair of buffer positions indicating that this
 report applies to that region."
   (let* ((state (gethash backend flymake--backend-state))
-         (first-report (not (flymake--backend-state-reported-p state))))
+         first-report)
+    (unless state
+      (error "Can't find state for %s in `flymake--backend-state'" backend))
+    (setf first-report (not (flymake--backend-state-reported-p state)))
     (setf (flymake--backend-state-reported-p state) t)
     (let (expected-token
           new-diags)