From: Richard M. Stallman Date: Sun, 24 Sep 2006 20:43:32 +0000 (+0000) Subject: (describe-key, describe-key-briefly): Test last event for being a down-event. X-Git-Tag: emacs-pretest-22.0.90~355 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=badf89eaea4e8937d8861589991306894dc5e541;p=emacs.git (describe-key, describe-key-briefly): Test last event for being a down-event. --- diff --git a/lisp/help.el b/lisp/help.el index 10ad5fe6deb..b79e028b633 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -571,16 +571,9 @@ temporarily enables it to allow getting help on disabled items and buttons." ;; down-events on scroll bars and mode lines: the actual ;; event then is in the second element of the vector. (and (vectorp key) - (or (and (eventp (aref key 0)) - (memq 'down (event-modifiers (aref key 0))) - ;; However, for the C-down-mouse-2 popup - ;; menu, there is no subsequent up-event. In - ;; this case, the up-event is the next - ;; element in the supplied vector. - (= (length key) 1)) - (and (> (length key) 1) - (eventp (aref key 1)) - (memq 'down (event-modifiers (aref key 1))))) + (let ((last-idx (1- (length key)))) + (and (eventp (aref key last-idx)) + (memq 'down (event-modifiers (aref key last-idx))))) (read-event)) (list key @@ -648,9 +641,14 @@ temporarily enables it to allow getting help on disabled items and buttons." (list key (prefix-numeric-value current-prefix-arg) - ;; If KEY is a down-event, read the corresponding up-event - ;; and use it as the third argument. + ;; If KEY is a down-event, read and discard the + ;; corresponding up-event. Note that there are also + ;; down-events on scroll bars and mode lines: the actual + ;; event then is in the second element of the vector. (and (vectorp key) + (let ((last-idx (1- (length key)))) + (and (eventp (aref key last-idx)) + (memq 'down (event-modifiers (aref key last-idx))))) (or (and (eventp (aref key 0)) (memq 'down (event-modifiers (aref key 0))) ;; However, for the C-down-mouse-2 popup