From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Mon, 28 Mar 2005 14:52:02 +0000 (+0000)
Subject: (window-buffer-height): Use count-screen-lines.
X-Git-Tag: ttn-vms-21-2-B4~1438
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ba96f392009080f6262c8287635868e11ae56747;p=emacs.git

(window-buffer-height): Use count-screen-lines.
---

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 46f5bdc0880..5fe346e9840 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,7 @@
 2005-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+	* window.el (window-buffer-height): Use count-screen-lines.
+
 	* progmodes/python.el (python-preoutput-leftover): New var.
 	(python-preoutput-filter): Use it.
 	(python-send-receive): Loop until all the result has been received.
diff --git a/lisp/window.el b/lisp/window.el
index 5768436eaae..b4fd664a43c 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -397,20 +397,13 @@ lines than are actually needed in the case where some error may be present."
 
 (defun window-buffer-height (window)
   "Return the height (in screen lines) of the buffer that WINDOW is displaying."
-  (save-excursion
-    (set-buffer (window-buffer window))
-    (goto-char (point-min))
-    (let ((ignore-final-newline
-           ;; If buffer ends with a newline, ignore it when counting height
-           ;; unless point is after it.
-           (and (not (eobp)) (eq ?\n (char-after (1- (point-max)))))))
-      (+ 1 (nth 2 (compute-motion (point-min)
-                                  '(0 . 0)
-                                  (- (point-max) (if ignore-final-newline 1 0))
-                                  (cons 0 100000000)
-                                  nil
-                                  nil
-                                  window))))))
+  (with-current-buffer (window-buffer window)
+    (max 1
+	 (count-screen-lines (point-min) (point-max)
+			     ;; If buffer ends with a newline, ignore it when
+			     ;; counting height unless point is after it.
+			     (eobp)
+			     window))))
 
 (defun count-screen-lines (&optional beg end count-final-newline window)
   "Return the number of screen lines in the region.