From: Adam Porter <adam@alphapapa.net>
Date: Thu, 21 Mar 2024 07:13:28 +0000 (-0500)
Subject: Avoid recomputing the whole table in 'vtable--recompute-numerical'
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b84c256895af9d6c48b682de27e3be9c99e0f749;p=emacs.git

Avoid recomputing the whole table in 'vtable--recompute-numerical'

Each element of LINE being tested is a list, the first element of
which is the value actually being represented in the table.
Previously, the 'numberp' test would always fail, because it was
being compared with the list rather than the intended value in it;
that could cause the whole table to be recomputed, sometimes
unnecessarily.
* lisp/emacs-lisp/vtable.el (vtable--recompute-numerical): Test the
car of ELEM, not ELEM itself, which is a list.  (Bug#69927)

(cherry picked from commit b3f04eb68499f285e05b5b74e9cbd67f3140fb3c)
---

diff --git a/lisp/emacs-lisp/vtable.el b/lisp/emacs-lisp/vtable.el
index 15a430f5c26..5f7d3ae5210 100644
--- a/lisp/emacs-lisp/vtable.el
+++ b/lisp/emacs-lisp/vtable.el
@@ -743,7 +743,7 @@ If NEXT, do the next column."
     (seq-do-indexed
      (lambda (elem index)
        (when (and (vtable-column--numerical (elt columns index))
-                  (not (numberp elem)))
+                  (not (numberp (car elem))))
          (setq recompute t)))
      line)
     (when recompute