From: João Távora Date: Sun, 10 Feb 2019 12:05:52 +0000 (+0000) Subject: Cleanup stale diagnostics on Flymake restart X-Git-Tag: emacs-27.0.90~3639 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b78363eb0f51126b2c22d26ea1b91f6e4569e167;p=emacs.git Cleanup stale diagnostics on Flymake restart Not doing so would cause duplicate diagnostics. See https://github.com/joaotavora/eglot/issues/223 for an example. * lisp/progmodes/flymake.el (Version): 1.0.4 (flymake-mode): Cleanup overlays before starting Flymake. --- diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index d7cb226773c..15a4d259859 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -4,7 +4,7 @@ ;; Author: Pavel Kobyakov ;; Maintainer: João Távora -;; Version: 1.0.3 +;; Version: 1.0.4 ;; Package-Requires: ((emacs "26.1")) ;; Keywords: c languages tools @@ -974,6 +974,11 @@ special *Flymake log* buffer." :group 'flymake :lighter (add-hook 'after-save-hook 'flymake-after-save-hook nil t) (add-hook 'kill-buffer-hook 'flymake-kill-buffer-hook nil t) + ;; If Flymake happened to be alrady already ON, we must cleanup + ;; existing diagnostic overlays, lest we forget them by blindly + ;; reinitializing `flymake--backend-state' in the next line. + ;; See https://github.com/joaotavora/eglot/issues/223. + (mapc #'delete-overlay (flymake--overlays)) (setq flymake--backend-state (make-hash-table)) (setq flymake--recent-changes nil)