From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 29 Aug 2011 19:59:51 +0000 (-0700)
Subject: * xfns.c (x_window): Make sprintf buffer a bit bigger
X-Git-Tag: emacs-pretest-24.0.90~104^2~153^2~1^2~16
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b7163a504a0b26e0068b6bc37a2b192e5e0cdac8;p=emacs.git

* xfns.c (x_window): Make sprintf buffer a bit bigger

to avoid potential buffer overrun.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index aeb984ee8df..53344aa7dd9 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -94,6 +94,9 @@
 	* xfaces.c (x_update_menu_appearance): Don't overrun buffer
 	if X resource line is longer than 512 bytes.
 
+	* xfns.c (x_window): Make sprintf buffer a bit bigger
+	to avoid potential buffer overrun.
+
 2011-08-26  Paul Eggert  <eggert@cs.ucla.edu>
 
 	Integer and memory overflow issues (Bug#9196).
diff --git a/src/xfns.c b/src/xfns.c
index 9a3d5fcda83..194a8f063b7 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -2440,7 +2440,7 @@ x_window (struct frame *f, long window_prompting, int minibuffer_only)
   /* Do some needed geometry management.  */
   {
     ptrdiff_t len;
-    char *tem, shell_position[32];
+    char *tem, shell_position[sizeof "=x++" + 4 * INT_STRLEN_BOUND (int)];
     Arg gal[10];
     int gac = 0;
     int extra_borders = 0;