From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri, 19 Feb 2021 17:51:36 +0000 (-0500)
Subject: * lisp/emacs-lisp/bytecomp.el: Don't warn for repeated _ args
X-Git-Tag: emacs-28.0.90~3646
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b6eccad06c89eea878c1464571255fe8ce5c6d86;p=emacs.git

* lisp/emacs-lisp/bytecomp.el: Don't warn for repeated _ args

(byte-compile-check-lambda-list): Skip warnings of repeated arg for
those that are declared as unused anyway.
---

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 9d80afd774f..1b0906b50bb 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2859,7 +2859,9 @@ If FORM is a lambda or a macro, byte-compile it as a function."
 	      ((eq arg '&optional)
                (when (memq '&optional (cdr list))
                  (error "Duplicate &optional")))
-	      ((memq arg vars)
+	      ((and (memq arg vars)
+	            ;; Allow repetitions for unused args.
+	            (not (string-match "\\`_" (symbol-name arg))))
 	       (byte-compile-warn "repeated variable %s in lambda-list" arg))
 	      (t
 	       (push arg vars))))