From: Po Lu <luangruo@yahoo.com>
Date: Sat, 22 Jan 2022 07:01:28 +0000 (+0800)
Subject: Get rid of some unnecessary code in handle_one_xevent
X-Git-Tag: emacs-29.0.90~2876^2
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b63baeafd24c506863da280e03efdcf0d1d8d0eb;p=emacs.git

Get rid of some unnecessary code in handle_one_xevent

* src/xterm.c (handle_one_xevent): Stop mutating event->xkey.
---

diff --git a/src/xterm.c b/src/xterm.c
index 81baeddbcaa..36e0045d2ed 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -9276,7 +9276,8 @@ handle_one_xevent (struct x_display_info *dpyinfo,
           int modifiers;
           Lisp_Object coding_system = Qlatin_1;
 	  Lisp_Object c;
-	  /* Event will be modified.  */
+	  /* `xkey' will be modified, but it's not important to modify
+	     `event' itself.  */
 	  XKeyEvent xkey = event->xkey;
 
 #ifdef USE_GTK
@@ -9538,8 +9539,6 @@ handle_one_xevent (struct x_display_info *dpyinfo,
 	    if (keysym == NoSymbol)
 	      break;
 	  }
-	  /* FIXME: check side effects and remove this.  */
-	  ((XEvent *) event)->xkey = xkey;
         }
     done_keysym:
 #ifdef HAVE_X_I18N