From: Eshel Yaron Date: Sun, 20 Aug 2023 14:29:33 +0000 (+0200) Subject: Rename 'package-vc-allow-side-effects' to better fit its use X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b2ba4cb8708996e75cd77b1f218b8ec34d6796d3;p=emacs.git Rename 'package-vc-allow-side-effects' to better fit its use * lisp/emacs-lisp/package-vc.el (package-vc-allow-side-effects): Rename to 'package-vc-allow-build-commands'. (package-vc--unpack-1): Use new name. * doc/emacs/package.texi (Fetching Package Sources): Use new name. * etc/NEWS: Adapt accordingly. (Bug#65386) --- diff --git a/doc/emacs/package.texi b/doc/emacs/package.texi index b294e3d58bd..96ebd35f547 100644 --- a/doc/emacs/package.texi +++ b/doc/emacs/package.texi @@ -690,13 +690,13 @@ an Org file. @item :make A string or list of strings providing the target or targets defined in the repository Makefile which should run before building the Info -file. Only takes effect when @code{package-vc-allow-side-effects} is -non-nil. +file. Only takes effect when @code{package-vc-allow-build-commands} +is non-nil. @item :shell-command A string providing the shell command to run before building the Info -file. Only takes effect when @code{package-vc-allow-side-effects} is -non-@code{nil}. +file. Only takes effect when @code{package-vc-allow-build-commands} +is non-@code{nil}. @item :vc-backend A symbol naming the VC backend to use for downloading a copy of the diff --git a/etc/NEWS b/etc/NEWS index 0c9275f1e10..cebf80bc86c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -538,9 +538,9 @@ project, that you can quickly select using 'project-switch-project' ('C-x p p'). --- -*** New user option 'package-vc-allow-side-effects'. -When non-nil, package specifications with side-effects for building -software will be used when building a package. +*** New user option 'package-vc-allow-build-commands'. +Controls for which packages Emacs runs extra build commands when +installing directly from the package VCS repository. --- *** New command to start an inferior Emacs loading only specific packages. diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index d225e61646c..747fe696204 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -362,7 +362,7 @@ asynchronously." "\n") nil pkg-file nil 'silent)))) -(defcustom package-vc-allow-side-effects nil +(defcustom package-vc-allow-build-commands nil "Whether to run extra build commands when installing VC packages. Some packages specify \"make\" targets or other shell commands @@ -548,9 +548,9 @@ documentation and marking the package as installed." (package-vc--generate-description-file pkg-desc pkg-file) ;; Process :make and :shell-command arguments before building documentation - (when (or (eq package-vc-allow-side-effects t) + (when (or (eq package-vc-allow-build-commands t) (memq (package-desc-name pkg-desc) - package-vc-allow-side-effects)) + package-vc-allow-build-commands)) (package-vc--make pkg-spec pkg-desc)) ;; Detect a manual