From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 26 Feb 2025 02:15:37 +0000 (+0100)
Subject: ; Prefer incf/decf in image-dired
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b1f6adb0ddd4126f463801b683eb6d842dd993b8;p=emacs.git

; Prefer incf/decf in image-dired

* lisp/image/image-dired-dired.el (image-dired-mark-tagged-files):
* lisp/image/image-dired.el (image-dired-gallery-generate):
Prefer incf/decf.

(cherry picked from commit 68f9a7aac1f5b9606ca6245e1dd74d09087752d4)
---

diff --git a/lisp/image/image-dired-dired.el b/lisp/image/image-dired-dired.el
index c7994cd4096..a7d5ad7c3ec 100644
--- a/lisp/image/image-dired-dired.el
+++ b/lisp/image/image-dired-dired.el
@@ -384,7 +384,7 @@ matching tag will be marked in the Dired buffer."
         (setq curr-file (file-name-nondirectory curr-file))
         (goto-char (point-min))
         (when (search-forward-regexp (format "\\s %s[*@]?$" (regexp-quote curr-file)) nil t)
-          (setq hits (+ hits 1))
+          (incf hits)
           (dired-mark 1))))
     (message "%d files with matching tag marked" hits)))
 
diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
index 5034d5890cd..5d637620a52 100644
--- a/lisp/image/image-dired.el
+++ b/lisp/image/image-dired.el
@@ -1990,7 +1990,7 @@ when using per-directory thumbnail file storage"))
               (setq tag-link-list
                     (append tag-link-list (list (cons tag tag-link))))
             (setq tag-link-list (list (cons tag tag-link))))
-          (setq count (1+ count))))
+          (incf count)))
       (setq count 1)
       ;; Main loop where we generated thumbnail pages per tag
       (dolist (curr tags)
@@ -2037,7 +2037,7 @@ when using per-directory thumbnail file storage"))
             (insert "  <p><a href=\"index.html\">Index</a></p>\n")
             (insert "  </body>\n")
             (insert "</html>\n"))
-          (setq count (1+ count))))
+          (incf count)))
       (insert "  </body>\n")
       (insert "</html>"))))
 
@@ -2099,7 +2099,7 @@ when using per-directory thumbnail file storage"))
 ;;        (format "Size of thumbnail directory: %d, delete old file %s? "
 ;;                dirsize (cadr (cdar files))))
 ;;       (delete-file (cadr (cdar files)))
-;;       (setq dirsize (- dirsize (car (cdar files))))
+;;       (decf dirsize (car (cdar files)))
 ;;       (setq files (cdr files)))))
 
 (provide 'image-dired)