From: Jim Porter <jporterbugs@gmail.com>
Date: Sat, 2 Sep 2023 23:07:59 +0000 (-0700)
Subject: ; Add debug instrumentation for Eshell argument modifiers
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=b0427f5ffe17c5a2a2aa0d993b164739c16193c0;p=emacs.git

; Add debug instrumentation for Eshell argument modifiers

* lisp/eshell/esh-arg.el (eshell-resolve-current-argument): Add debug
instrumentation, and simplify modifier application.
---

diff --git a/lisp/eshell/esh-arg.el b/lisp/eshell/esh-arg.el
index 26be1127880..e9c6a7f2f68 100644
--- a/lisp/eshell/esh-arg.el
+++ b/lisp/eshell/esh-arg.el
@@ -293,10 +293,13 @@ then the result will be:
               (append (list 'eshell-concat eshell-current-quoted)
                       eshell-current-argument)))
       (setq eshell-arg-listified nil))
-    (while eshell-current-modifiers
+    (when eshell-current-modifiers
+      (eshell-debug-command 'form (format-message "applying modifiers %S"
+                                                  eshell-current-modifiers)
+                            eshell-current-argument))
+    (dolist (modifier eshell-current-modifiers)
       (setq eshell-current-argument
-	    (list (car eshell-current-modifiers) eshell-current-argument)
-	    eshell-current-modifiers (cdr eshell-current-modifiers))))
+            (list modifier eshell-current-argument))))
   (setq eshell-current-modifiers nil))
 
 (defun eshell-finish-arg (&rest arguments)