From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Wed, 18 Feb 2015 16:04:15 +0000 (-0500)
Subject: * lisp/emacs-lisp/checkdoc.el (checkdoc-show-diagnostics): Don't make bogus
X-Git-Tag: emacs-25.0.90~2564^2~356
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=ad6c1be9230ac8ed517a51778b586055edb952c3;p=emacs.git

* lisp/emacs-lisp/checkdoc.el (checkdoc-show-diagnostics): Don't make bogus

assumptions about window ordering.
---

diff --git a/etc/NEWS b/etc/NEWS
index 0295245d120..f359f9168b2 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -235,6 +235,7 @@ If you need your objects to be named, do it by inheriting from `eieio-named'.
 *** The <class> variables are declared obsolete.
 *** The <initarg> variables are declared obsolete.
 *** defgeneric and defmethod are declared obsolete.
+*** `constructor' is now an obsolete alias for `make-instance'.
 
 ** ido
 *** New command `ido-bury-buffer-at-head' bound to C-S-b
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 704ec34606c..f6831508471 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+	* emacs-lisp/checkdoc.el (checkdoc-show-diagnostics): Don't make bogus
+	assumptions about window ordering.
+
 2015-02-16  Kelly Dean  <kelly@prtime.org>
 
 	* lisp/files.el (insert-file-contents-literally): Fix docstring typo.
diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el
index 47b6e5f81de..288e25e6060 100644
--- a/lisp/emacs-lisp/checkdoc.el
+++ b/lisp/emacs-lisp/checkdoc.el
@@ -2619,14 +2619,15 @@ function called to create the messages."
 (defun checkdoc-show-diagnostics ()
   "Display the checkdoc diagnostic buffer in a temporary window."
   (if checkdoc-pending-errors
-      (let ((b (get-buffer checkdoc-diagnostic-buffer)))
-	(if b (progn (pop-to-buffer b)
-		     (goto-char (point-max))
-		     (re-search-backward "\C-l" nil t)
-		     (beginning-of-line)
-		     (forward-line 1)
-		     (recenter 0)))
-	(other-window -1)
+      (let* ((b (get-buffer checkdoc-diagnostic-buffer))
+             (win (if b (display-buffer b))))
+	(when win
+          (with-selected-window win
+            (goto-char (point-max))
+            (re-search-backward "\C-l" nil t)
+            (beginning-of-line)
+            (forward-line 1)
+            (recenter 0)))
 	(setq checkdoc-pending-errors nil)
 	nil)))