From: João Távora <joaotavora@gmail.com>
Date: Tue, 5 Jun 2018 13:31:38 +0000 (+0100)
Subject: Correctly filter Flymake diagnostic types shown in mode-line
X-Git-Tag: emacs-27.0.90~4928
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=aadac04923c9ae47f0bccc706857b94166c9d355;p=emacs.git

Correctly filter Flymake diagnostic types shown in mode-line

Thus, if a package foo has its own types foo-error and
foo-warning, and if the buffer has no errors, the mode-line
will correctly show `[0 0]' (zero errors and warnings) instead
of `[0 0 0 0]' (zero errors, zero foo-errors, zero warnings,
zero  foo-warnings).

* lisp/progmodes/flymake.el
(flymake--mode-line-format): Coalesce diagnostic types based on
the severity, not the symbol.
---

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 35d56725445..ec933ad16ba 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1068,14 +1068,17 @@ applied."
       ,@(unless (or all-disabled
                     (null known))
           (cl-loop
+           with get-severity = (lambda (type)
+                                 (flymake--lookup-type-property
+                                  type
+                                  'severity
+                                  (warning-numeric-level :error)))
            for (type . severity)
            in (cl-sort (mapcar (lambda (type)
-                                 (cons type (flymake--lookup-type-property
-                                             type
-                                             'severity
-                                             (warning-numeric-level :error))))
+                                 (cons type (funcall get-severity type)))
                                (cl-union (hash-table-keys diags-by-type)
-                                         '(:error :warning)))
+                                         '(:error :warning)
+                                         :key get-severity))
                        #'>
                        :key #'cdr)
            for diags = (gethash type diags-by-type)