From: João Távora <joaotavora@gmail.com>
Date: Sun, 5 Nov 2017 14:58:07 +0000 (+0000)
Subject: Fix Flymake help-echo functions across windows (bug#29142)
X-Git-Tag: emacs-26.0.91~373
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=a2cc6d74c5b94633e7fc044765e0ef40a8d63f50;p=emacs.git

Fix Flymake help-echo functions across windows (bug#29142)

* lisp/progmodes/flymake.el (flymake--highlight-line): Use
with-selected-window.
(flymake-goto-next-error): Call help-echo with a window and an
overlay.
---

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e13d79770e5..e833cd949ee 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -520,11 +520,12 @@ associated `flymake-category' return DEFAULT."
         (flymake--fringe-overlay-spec
          (overlay-get ov 'bitmap)))
       (default-maybe 'help-echo
-        (lambda (_window _ov pos)
-          (mapconcat
-           #'flymake--diag-text
-           (flymake-diagnostics pos)
-           "\n")))
+        (lambda (window _ov pos)
+          (with-selected-window window
+            (mapconcat
+             #'flymake--diag-text
+             (flymake-diagnostics pos)
+             "\n"))))
       (default-maybe 'severity (warning-numeric-level :error))
       (default-maybe 'priority (+ 100 (overlay-get ov 'severity))))
     ;; Some properties can't be overridden.
@@ -949,7 +950,7 @@ applied."
              (message
               "%s"
               (funcall (overlay-get target 'help-echo)
-                       nil nil (point)))))
+                       (selected-window) target (point)))))
           (interactive
            (user-error "No more Flymake errors%s"
                        (if filter