From: Eli Zaretskii <eliz@gnu.org>
Date: Mon, 17 Aug 2020 16:43:29 +0000 (+0300)
Subject: Don't use -Wsuggest-attribute=malloc by default
X-Git-Tag: emacs-28.0.90~6575
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=a1fe15a6ce7996504a2a422ac59f3494aa20819f;p=emacs.git

Don't use -Wsuggest-attribute=malloc by default

* configure.ac: Move -Wsuggest-attribute=malloc to the set used
only under --enable-gcc-warnings.
---

diff --git a/configure.ac b/configure.ac
index 745ff22d354..ace1085284e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1026,7 +1026,10 @@ AS_IF([test $gl_gcc_warnings = no],
     [# Use -fanalyzer and related options only if --enable-gcc-warnings,
      # as they slow GCC considerably.
      nw="$nw -fanalyzer -Wno-analyzer-double-free -Wno-analyzer-malloc-leak"
-     nw="$nw -Wno-analyzer-null-dereference -Wno-analyzer-use-after-free"])
+     nw="$nw -Wno-analyzer-null-dereference -Wno-analyzer-use-after-free"
+     # Use -Wsuggest-attribute=malloc only if --enable-gcc-warnings,
+     # as it doesn't flag code that is wrong in any way.
+     nw="$nw -Wsuggest-attribute=malloc"])
 
   nw="$nw -Wcast-align=strict"      # Emacs is tricky with pointers.
   nw="$nw -Wduplicated-branches"    # Too many false alarms