From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Tue, 27 Jul 2021 15:23:32 +0000 (+0200)
Subject: Revert "Make revert-buffer preserve buffer-readedness"
X-Git-Tag: emacs-28.0.90~1679
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=989937e1bc29ffec3835aee34c46479d25d0bf05;p=emacs.git

Revert "Make revert-buffer preserve buffer-readedness"

This reverts commit fcae435f598471a2911641412125c5ac4f73559f.

This leads to problems when reverting from a file that's changed
readedness externally.
---

diff --git a/etc/NEWS b/etc/NEWS
index b969590f7c3..3513fa4d642 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2827,9 +2827,6 @@ similar to prefix arguments, but are more flexible and discoverable.
 
 * Incompatible Editing Changes in Emacs 28.1
 
-** 'revert-buffer' will now preserve buffer-readedness.
-It previously switched the read-only flag off.
-
 ** 'electric-indent-mode' now also indents inside strings and comments,
 (unless the indentation function doesn't, of course).
 To recover the previous behavior you can use:
diff --git a/lisp/files.el b/lisp/files.el
index 60888226865..0bf866d0ece 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -6364,9 +6364,7 @@ preserve markers and overlays, at the price of being slower."
   ;; interface, but leaving the programmatic interface the same.
   (interactive (list (not current-prefix-arg)))
   (let ((revert-buffer-in-progress-p t)
-        (revert-buffer-preserve-modes preserve-modes)
-        ;; Preserve buffer-readedness.
-        (buffer-read-only buffer-read-only))
+        (revert-buffer-preserve-modes preserve-modes))
     (funcall (or revert-buffer-function #'revert-buffer--default)
              ignore-auto noconfirm)))