From: Glenn Morris <rgm@gnu.org>
Date: Tue, 25 Nov 2008 04:26:22 +0000 (+0000)
Subject: (eshell-gather-process-output): Revert previous change.  (re-opens Bug#1388)
X-Git-Tag: emacs-pretest-23.0.90~1531
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=975c500dacaa09bbfb413babe34c996e63286835;p=emacs.git

(eshell-gather-process-output): Revert previous change.  (re-opens Bug#1388)
---

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 93fb6babcd7..e911bd027c7 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,12 @@
+2008-11-25  Glenn Morris  <rgm@gnu.org>
+
+	* eshell/esh-proc.el (eshell-gather-process-output):
+	Revert previous change.  (re-opens Bug#1388)
+
+	* select.el (x-set-cut-buffer): Fix signal arguments.
+
+	* speedbar.el (speedbar-restricted-move): Fix signal arguments.
+
 2008-11-25  Juanma Barranquero  <lekktu@gmail.com>
 
 	* play/bubbles.el (bubbles-mode): Define with `define-derived-mode'.
@@ -143,7 +152,7 @@
 
 2008-11-24  Dan Nicolaescu  <dann@ics.uci.edu>
 
-	* vc-hg.el (vc-hg-global-switches): Remove.
+	* vc-hg.el (vc-hg-program): Remove.
 	(vc-hg-state, vc-hg-working-revision, vc-hg-command):
 	Undo previous change.
 
diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el
index 39fea83cd8d..25d9dd64663 100644
--- a/lisp/eshell/esh-proc.el
+++ b/lisp/eshell/esh-proc.el
@@ -250,27 +250,11 @@ Used only on systems which do not support async subprocesses.")
     (cond
      ((fboundp 'start-process)
       (setq proc
-	    ;; Bug#1388.  Some commands (eg bc) check isatty to decide
-	    ;; whether they are being called interactively.
-	    ;; A normal shell pipeline has:
-	    ;; first: stdin tty , stdout pipe
-	    ;; rest : stdin pipe, stdout pipe
-	    ;; last : stdin pipe, stdout tty
-	    ;; We have:
-	    ;; first: stdin tty , stdout tty
-	    ;; last : stdin pipe, stdout pipe
-	    ;; In other words, the first and last elements have the
-	    ;; wrong kind of stdout.  (Perhaps this does not matter much...)
-	    ;; FIXME which is better for the first element:
-	    ;; tty/tty (as now), or pipe/pipe?
-	    (let ((process-connection-type
-		   (unless (and eshell-in-pipeline-p
-				(not (eq eshell-in-pipeline-p 'first)))
-		     process-connection-type)))
-	      (apply 'start-process
-		     (file-name-nondirectory command) nil
-		     ;; `start-process' can't deal with relative filenames
-		     (append (list (expand-file-name command)) args))))
+	    (apply 'start-process
+		   (file-name-nondirectory command) nil
+		   ;; `start-process' can't deal with relative
+		   ;; filenames
+		   (append (list (expand-file-name command)) args)))
       (eshell-record-process-object proc)
       (set-process-buffer proc (current-buffer))
       (if (eshell-interactive-output-p)