From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sat, 21 Nov 2020 00:28:34 +0000 (-0500)
Subject: * lisp/emacs-lisp/package.el (package-strip-rcs-id): Don't ignore errors
X-Git-Tag: emacs-28.0.90~5077
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=932cb10761b9f249c87d7c19778873691f2a5d46;p=emacs.git

* lisp/emacs-lisp/package.el (package-strip-rcs-id): Don't ignore errors

Ignoring errors here just postpones the error and replaces a clear
"invalid version syntax" with a confusing "package lacks a version".
---

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index d78a1a2856a..9c37ce429a7 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2112,8 +2112,7 @@ Otherwise return nil."
   (when str
     (when (string-match "\\`[ \t]*[$]Revision:[ \t]+" str)
       (setq str (substring str (match-end 0))))
-    (ignore-errors
-      (if (version-to-list str) str))))
+    (if (version-to-list str) str)))
 
 (declare-function lm-homepage "lisp-mnt" (&optional file))