From: Eli Zaretskii <eliz@gnu.org>
Date: Thu, 8 Jun 2023 09:23:11 +0000 (+0300)
Subject: Revert "* package.el (package--get-activatable-pkg): Prefer source packages"
X-Git-Tag: emacs-29.0.92~42
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=90eadc3e2349c155a14aedb6cf09d9c571d8e698;p=emacs.git

Revert "* package.el (package--get-activatable-pkg): Prefer source packages"

This reverts commit fb87d5008e21d1bc03547c1edf2280fb4cb8311e.
It caused problems when new versions of packages are installed
without deleting old versions.  (Bug#63757)
---

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 43368b59522..3e6acd9b388 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -924,22 +924,14 @@ correspond to previously loaded files."
 
 (defun package--get-activatable-pkg (pkg-name)
   ;; Is "activatable" a word?
-  (let ((pkg-descs (sort (cdr (assq pkg-name package-alist))
-                         (lambda (p1 p2)
-                           (let ((v1 (package-desc-version p1))
-                                 (v2 (package-desc-version p2)))
-                             (or
-                              ;; Prefer VC packages.
-                              (package-vc-p p1)
-                              (package-vc-p p2)
-                              ;; Prefer builtin packages.
-                              (package-disabled-p p1 v1)
-                              (not (package-disabled-p p2 v2))))))))
+  (let ((pkg-descs (cdr (assq pkg-name package-alist))))
     ;; Check if PACKAGE is available in `package-alist'.
     (while
         (when pkg-descs
           (let ((available-version (package-desc-version (car pkg-descs))))
-            (package-disabled-p pkg-name available-version)))
+            (or (package-disabled-p pkg-name available-version)
+                ;; Prefer a builtin package.
+                (package-built-in-p pkg-name available-version))))
       (setq pkg-descs (cdr pkg-descs)))
     (car pkg-descs)))