From: Troy Hinckley <t.macman@gmail.com>
Date: Wed, 16 Jan 2019 22:47:07 +0000 (-0800)
Subject: Don't check comp-buffer-name-function in derived mode (Bug#34956)
X-Git-Tag: emacs-27.0.90~3261^2~104
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=905f6195191a518b7bb2dbdf6eacae41d31fc54e;p=emacs.git

Don't check comp-buffer-name-function in derived mode (Bug#34956)

* lisp/progmodes/compile.el (define-compilation-mode): Remove
'compilation-buffer-name-function' from the list of overridden
variables to ensure that it is not mistaken for a variable that can be
major mode specific.  'compilation-buffer-name-function' is used
before the major mode is loaded, therefore overriding it here is
ineffectual.  Also, the function 'compilation-start' takes an optional
argument name-function, so there is already a mechanism to override
it.
---

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6d5775209c0..1a0d9bdbb70 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2056,8 +2056,7 @@ by replacing the first word, e.g., `compilation-scroll-output' from
 			    (if (boundp 'byte-compile-bound-variables)
 				(memq (cdr v) byte-compile-bound-variables)))
 			`(set (make-local-variable ',(car v)) ,(cdr v))))
-		 '(compilation-buffer-name-function
-		   compilation-directory-matcher
+		 '(compilation-directory-matcher
 		   compilation-error
 		   compilation-error-regexp-alist
 		   compilation-error-regexp-alist-alist